Skip to content

Conversation

@xcrsz
Copy link
Contributor

@xcrsz xcrsz commented Nov 16, 2025

Add support to copy pre-defined conf files to the ISO's /boot/loader.conf.d directory.

Summary by Sourcery

Add support for applying pre-defined loader.conf.d configurations by introducing a new patch_loader_conf_d function that copies and sets permissions for .conf files into the ISO’s /boot/loader.conf.d directory.

New Features:

  • Introduce patch_loader_conf_d function to detect and copy .conf files from patches/boot/loader.conf.d into the release ISO
  • Create target /boot/loader.conf.d directory and set file permissions

Enhancements:

  • Silently handle missing patch files or directories to avoid errors during ISO assembly

Add support to copy pre-defined conf files to the ISO's  /boot/loader.conf.d directory.
@xcrsz xcrsz requested review from a team as code owners November 16, 2025 12:15
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds a new shell function, patch_loader_conf_d, to common_config/base-setting.sh that automates copying pre-generated .conf files into the ISO’s /boot/loader.conf.d directory, including directory creation and permission setting.

Class diagram for shell functions in base-setting.sh after patch_loader_conf_d addition

classDiagram
    class patch_etc_files {
        +cat devfs.rules.extra >> /etc/devfs.rules
        +cat fstab.extra >> /etc/fstab
        +mkdir -p /compat/linux/dev/shm
        +mkdir -p /compat/linux/sys
    }
    class patch_loader_conf_d {
        +check if patches_dir exists
        +mkdir -p /boot/loader.conf.d
        +cp *.conf to /boot/loader.conf.d/
        +chmod 644 *.conf in /boot/loader.conf.d
    }
Loading

File-Level Changes

Change Details Files
Introduce patch_loader_conf_d function to handle loader.conf.d configuration files
  • Define patches_dir variable pointing to boot/loader.conf.d patches
  • Check if the patches directory exists
  • Create target /boot/loader.conf.d directory under release
  • Copy all .conf files verbosely, suppressing errors
  • Set file permissions to 644 on the copied .conf files
common_config/base-setting.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.


patch_loader_conf_d()
{
local patches_dir="${cwd}/common_config/base-setting/patches/boot/loader.conf.d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./common_config/base-setting.sh:13:3: warning: In POSIX sh, 'local' is undefined. [SC3043]

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Development Tracker Nov 16, 2025
@ericbsd ericbsd merged commit 84e082b into ghostbsd:master Nov 16, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Tracker Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants