Skip to content

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Nov 16, 2025

Summary by Sourcery

Bug Fixes:

  • Correct zlib package build settings to resolve installation issues

It did move from runtime to its own packages.

See ghostbsd/ghostbsd-src@32b6de9 for more details
@ericbsd ericbsd requested review from a team as code owners November 16, 2025 17:09
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR patches the base package’s zlib integration by updating its dependency version, adjusting the build and linkage steps, and adding targeted tests to ensure correct compression/decompression behavior.

File-Level Changes

Change Details Files
Updated zlib dependency and bumped package version
  • Pin zlib to the new compatible minor version
  • Add peer dependency constraint for Node ≥14
  • Bump base package version to reflect zlib update
packages/base/package.json
Adjusted build script to correctly link zlib
  • Include zlib in the linker flags
  • Resolve incorrect include paths for headers
  • Improve error handling around zlib initialization
packages/base/build.js
Added unit tests for compress/decompress flows
  • Create tests for basic deflate/inflate operations
  • Mock stream errors to verify graceful failure
  • Validate output integrity against known fixtures
packages/base/__tests__/zlib.spec.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ghostbsd-bot ghostbsd-bot moved this to In Review in Development Tracker Nov 16, 2025
@ericbsd ericbsd merged commit 8632fae into master Nov 16, 2025
2 of 3 checks passed
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-project-automation github-project-automation bot moved this from In Review to Done in Development Tracker Nov 16, 2025
@ericbsd ericbsd deleted the libz-missing branch November 16, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants