Skip to content

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Nov 29, 2025

  • Replace wallpaper with "blue-layered-stripes.jpg."
  • Remove obsolete Git setup functions from script.

Summary by Sourcery

Update the MATE OEM configuration script to use the new default wallpaper and simplify the live system setup.

Bug Fixes:

  • Point the MATE OEM xinit configuration to the correct install-station-init command instead of the previous install-station command.

Enhancements:

  • Switch the default MATE OEM wallpaper to blue-layered-stripes.jpg for both live user and root sessions.
  • Remove obsolete Git-based setup functions from the MATE OEM provisioning flow to streamline system initialization.

- Replace wallpaper with "blue-layered-stripes.jpg."
- Remove obsolete Git setup functions from script.
@ericbsd ericbsd requested review from a team as code owners November 29, 2025 20:18
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the MATE OEM setup script to use a new default wallpaper and installation command, and removes obsolete Git-based setup calls that are no longer needed.

Sequence diagram for updated MATE OEM X session startup

sequenceDiagram
  actor User
  participant Lightdm as Lightdm
  participant XSession as X_session
  participant XinitrcLive as Xinitrc_live_user
  participant Marco as Marco_wm
  participant Feh as Feh_wallpaper
  participant InstallInit as Install_station_init

  User ->> Lightdm: Authenticate on login screen
  Lightdm ->> XSession: Start session for live_user
  XSession ->> XinitrcLive: Read .xinitrc commands
  XinitrcLive ->> Marco: exec marco &
  XinitrcLive ->> Feh: exec feh --bg-fill blue-layered-stripes.jpg &
  XinitrcLive ->> InstallInit: exec sudo install-station-init
  Marco -->> User: Provide window management
  Feh -->> User: Display blue-layered-stripes wallpaper
  InstallInit -->> User: Launch installation initialization
Loading

Flow diagram for updated mate_oem.sh setup process

flowchart TD
  A[mate_oem_sh_start] --> B[patch_etc_files]
  B --> C[patch_loader_conf_d]
  C --> D[ghostbsd_setup_liveuser]
  D --> E[ghostbsd_setup_autologin]
  E --> F[lightdm_setup]
  F --> G[setup_xinit]

  subgraph setup_xinit_logic
    G --> H[write_live_user_xinitrc_marco]
    H --> I[write_live_user_xinitrc_feh_blue_layered_stripes]
    I --> J[write_live_user_xinitrc_install_station_init]
    J --> K[chmod_live_user_xinitrc_765]
    K --> L[write_root_xinitrc_marco]
    L --> M[write_root_xinitrc_feh_blue_layered_stripes]
    M --> N[write_root_xinitrc_setup_station]
  end
Loading

File-Level Changes

Change Details Files
Update X11 startup configuration to use a new wallpaper and updated install-station command for live user and root.
  • Change feh background image path from Lake_View.jpg to blue-layered-stripes.jpg in generated .xinitrc for live user and root
  • Update the install-station invocation in the live user .xinitrc to use install-station-init instead
desktop_config/mate_oem.sh
Remove unused Git setup helper calls from the MATE OEM configuration flow.
  • Delete calls to git_pc_sysinstall, git_gbi, git_install_station, and git_setup_station at the end of the script
desktop_config/mate_oem.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit 1316fa7 into master Nov 29, 2025
3 checks passed
@ericbsd ericbsd deleted the fix-oem branch November 29, 2025 20:19
@ericbsd ericbsd moved this from In Review to Done in Development Tracker Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants