Skip to content

Conversation

@ghotso
Copy link
Owner

@ghotso ghotso commented Dec 15, 2025

No description provided.

- Added package index update and error handling for installing build dependencies (python3, make, g++) to ensure compatibility with ARM64 emulation.
- Included verification steps to confirm successful installation of required packages.
- Added sqlite-dev package to ensure successful compilation of better-sqlite3.
- Included verification step to confirm installation of sqlite-dev.
- Updated cleanup process to remove sqlite-dev while retaining runtime dependencies.
@ghotso
Copy link
Owner Author

ghotso commented Dec 15, 2025

Summary

This PR refactors the Dockerfile to improve package installation.

Positive Aspects

  • Installs sqlite-dev to ensure better-sqlite3 compiles correctly.
  • Adds checks to verify installation of build tools and sqlite headers.
  • Handles ARM64 emulation issues by ignoring harmless errors during package install.
  • Removes build dependencies after install to reduce image size.

Suggestions

  • The added verification commands add robustness, which is good.
  • Ensure that any failure in the Docker build stops the process as intended by the checks.

No functional or security risks detected.

Recommend merging after successful CI passes.

@ghotso ghotso merged commit 0191dbf into main Dec 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants