Make test running against latest QGIS versions #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@dmarteau first of all, thanks for taking this issue! Do you need more privileges in order to make some tests without approval? Let me know! |
Collaborator
|
Good move. Side note, would it be OK to have a look to qgis/qgis-docker#129 or to improve the provided QGIS docker image ? |
Owner
absolutely! thanks for the hint. @dmarteau can I help you in some way? |
Owner
|
@dmarteau is this PR still a draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #358
Changes
Modify the test infrastructure and workflow in order to enable the tests running against recent qgis image version (starting from 3.34).
The original issue is that the testing infrastructure used with old images seems to be totally deprecated: the simplest solution appears to be completely dropping it and run with standart unitetest tools and mock from the qgis testing api.
The tests have been pulled out the plugin code and run with pytest wich is (for my taste) a more versatile and powerful tool than unitests - its a suggestion, feel free not to use it.
Some tests fails but at least the test run even if It seems that there is is still a bit of work to set things up for good.