Skip to content

Make Worksheet#copy_to and Worksheet#duplicate returns copied Worksheet #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make Worksheet#copy_to and Worksheet#duplicate returns copied Worksheet #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/google_drive/worksheet.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ def copy_to(spreadsheet_or_id)
request = Google::Apis::SheetsV4::CopySheetToAnotherSpreadsheetRequest.new(
destination_spreadsheet_id: destination_spreadsheet_id,
)
@session.sheets_service.copy_spreadsheet(spreadsheet.id, sheet_id, request)
nil
response = @session.sheets_service.copy_spreadsheet(spreadsheet.id, sheet_id, request)
Worksheet.new(@session, spreadsheet, response)
end
Copy link

@y-bonfire y-bonfire Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I just happened to look at this PR and noticed something that might be causing issues.
I tried running it locally and it seems like the second argument to Worksheet.new needs to be the destination spreadsheet — otherwise it throws an error when accessing the copied worksheet.

For example, this worked for me:

response = @session.sheets_service.copy_spreadsheet(spreadsheet.id, sheet_id, request)
dest_spreadsheet = @session.spreadsheet_by_key(destination_spreadsheet_id)
Worksheet.new(@session, dest_spreadsheet, response)

Not sure if this is still relevant after all this time, but thought I’d share just in case!


# Copy worksheet to owner spreadsheet.
Expand Down