Allow regexp on AllowOrigins #36
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 93.02% 93.37% +0.34%
==========================================
Files 3 3
Lines 172 181 +9
==========================================
+ Hits 160 169 +9
Misses 11 11
Partials 1 1
Continue to review full report at Codecov.
|
|
Hi @arizz96 please add some test case thanks! |
# Conflicts: # config.go # cors.go
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
# Conflicts: # config.go # cors.go
|
@thinkerou thanks for the suggestion and sorry for 1+ year delay! |
|
Hi @appleboy @thinkerou , this PR is useful. |
| @@ -105,8 +106,14 @@ func (cors *cors) validateOrigin(origin string) bool { | |||
| if cors.allowAllOrigins { | |||
| return true | |||
| } | |||
| r, _ := regexp.Compile("^\\/(.+)\\/[gimuy]?$") | |||
There was a problem hiding this comment.
Move regexp.Compile to the top block as a global variable for better performance.
This PR enable use of regexp on CORS origin.
It can be useful to allow CORS in different subdomains of a single domain.
Regexp matching requires
/at the begin and at the end of regular expression.For example:
/^https?://(?:.+\.)?mywebsite\.com/gmatches all the subdomains of
mywebsite.com, in secure and insecure protocol.NOTE: in regexp,
.matches all characters, so be careful on update it correctly