Fix tests by providing a PostgreSQL database container (#141)

gin-contrib · Oct 28, 2021 · 9ca5251 · 9ca5251
1 parent 7217c24
commit 9ca5251
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
@@ -21,6 +21,14 @@ jobs:
         with:
           mongodb-version: 4.2
 
+      - name: Start PostgreSQL 14
+        uses: harmon758/postgresql-action@v1
+        with:
+          postgresql db: testdb
+          postgresql user: testuser
+          postgresql password: testpw
+          postgresql version: '14'
+
       - uses: niden/actions-memcached@v7
 
       - name: Set up Go ${{ matrix.go }}

diff --git a/postgres/postgres_test.go b/postgres/postgres_test.go
@@ -4,19 +4,13 @@ import (
 	"database/sql"
 	"github.com/gin-contrib/sessions"
 	"github.com/gin-contrib/sessions/tester"
-	"os"
 	"testing"
 )
 
+const postgresTestServer = "postgres://testuser:testpw@localhost:5432/testdb?sslmode=disable"
 
 var newStore = func(_ *testing.T) sessions.Store {
-	// Env var in the format postgresql://username:password@localhost:5432/database?sslmode=disable required
-	dsn := os.Getenv("SESSIONS_POSTGRES_TEST")
-	if dsn == "" {
-		panic("database connection is required")
-	}
-
-	db, err := sql.Open("postgres", dsn)
+	db, err := sql.Open("postgres", postgresTestServer)
 	if err != nil {
 		panic(err)
 	}