Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Conversation

dkerwin
Copy link
Contributor

@dkerwin dkerwin commented Nov 7, 2019

This PR reworks the way how providers are created. It is now possible to add arbitrary providers with very little overhead. Azure needs verification - I cannot test that.

This PR affects

Closes #23

@dkerwin
Copy link
Contributor Author

dkerwin commented Nov 7, 2019

Hey @cblims! Would it be possible for you to verify that the new azure provider works as expected? Your help would be highly appreciated

@dkerwin dkerwin mentioned this pull request Nov 7, 2019
@cblims
Copy link
Contributor

cblims commented Nov 7, 2019

Hi, just testet and it works. However "auto-configuration" mode does not. Normally I run dexter without any parameters to read current configuration from ~/.kube/config. Is this one removed?

@dkerwin
Copy link
Contributor Author

dkerwin commented Nov 7, 2019

@cblims Thanks for giving it a try. It should work. Could you share the logs and maybe even a anonymized snippet from you kube config so I could verify locally?

@cblims
Copy link
Contributor

cblims commented Nov 7, 2019

Running dexter auth azure starts authentication, but seems like it doesn't pick up the tenant id from idp-issuer-url. Here is a .kube/config dump. UUIDs in client-id and idp-issuer-url are fake. The UUID in idp-issuer-url is a tenant id.

- name: [email protected]
  user:
    auth-provider:
      config:
        client-id: a1209219-e181-41f3-9671-17bac336b8ae
        client-secret: redacted
        id-token: redacted
        idp-issuer-url: https://login.microsoftonline.com/096bd15c-4e79-47f8-b3d6-15519ec857c2/v2.0
      name: oidc

@dkerwin
Copy link
Contributor Author

dkerwin commented Nov 7, 2019

Hey @cblims.

azure issue should be fixed now. Would you mind giving it another spin?

@cblims
Copy link
Contributor

cblims commented Nov 8, 2019

in func AzureCommand azureProvider.tenant is always common when running without --tenant. Auto pilot mode kics in after microsoft.AzureADEndpoint is set. I can look into that sometime during this weekend.

Btw, before autopilot mode was initiated by only running dexter without any options. My initial thought introducing autopilot was to autodetect provider and its configuration based on kubectl context. Are you planning to remove this?

@dkerwin
Copy link
Contributor Author

dkerwin commented Nov 8, 2019

I really like the autopilot functionality. I think i will refactor it into a dedicated provider (something like dexter auth auto. Need to think about this a little more... Thanks

@dkerwin
Copy link
Contributor Author

dkerwin commented Nov 18, 2019

Autopilot is back to normal operation. OAuth2 endpoints for azure are constructed as expected.
@cblims: You could still use it as before. You just have to use the new azure subcommand

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a dedicated sub-command per provider

2 participants