Saving invoices Locally #851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d retrieve strings PP-1727:
… at one place PP-1727
… the design, this is temporary, will be changed according to new design PP-1727
… and will be changed in next commits PP-1727
…ill be changed in next commits PP-1727
…senter method PP-1727
… app, so the first time behaviour can be initiated again without uninstalling and re-install PP-1727
…e the indication about save invoice feature PP-1727
…cher for SAF PP-1727
… in orientation change, the lock was held forever and SDK was going to ANR state PP-1727
…entImpl that saving invoices feature is turned off or on PP-1727
… presenter related to SAF flow PP-1727
…ment implementation and presenter PP-1727
…ssed in Capture SDK PP-1727
…reEnabledUseCase can be accessed PP-1727
…ew should be shown depending on conditions or not PP-1727
…marking them gone PP-1727
… the right import method PP-1727
…nk sdk example app, also putting the button for clearing the path of SAF folder, to simulate "first time" flow where we get the permission from user PP-1727
…etween camera and picker file. PP-1727
…ed from outside of SDK PP-1727
… and using material switch 3 PP-1727
…a and also using new material switch 3 PP-1727
…o updated figma design PP-1727
… AnalysisScreenPresenter PP-1727
…eviewFragment PP-1727
…eviewFragment PP-1727
.../example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ConfigurationViewModel.kt
Show resolved
Hide resolved
...k/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ConfigurationActivity.kt
Outdated
Show resolved
Hide resolved
| static AnalysisFragmentImpl createFragmentImpl(@NonNull final FragmentImplCallback fragment, @NonNull CancelListener cancelListener, | ||
| @NonNull final Bundle arguments) { | ||
| final Document document = arguments.getParcelable(ARGS_DOCUMENT); | ||
| final Boolean mIsInvoiceSavingEnabled = arguments.getBoolean(GC_ARGS_SAVE_INVOICES, false); |
There was a problem hiding this comment.
could you explain me what is m in this name of "mIsInvoiceSavingEnabled" ?
MozhganPeivandianSharbaf
requested changes
Oct 23, 2025
There was a problem hiding this comment.
thank you @obaidgini, I just added some small comment, please check.
MozhganPeivandianSharbaf
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Ticket# PP-1727
Notes for Reviewers
Very Important classes for review
AnalysisFragmentImplAnalysisFragmentSAFHelperSaveInvoicesFeatureEvaluatorMultiPageReviewFragmentFragmentImplCallbackAnalysisScreenPresenterImportant
Please note that this is not completed yet, so the design related work is still in progress.
Thank you