-
Notifications
You must be signed in to change notification settings - Fork 3
Feat(GiniMerchantSDK): Migrate to universal links #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
motokotomax
wants to merge
1
commit into
main
Choose a base branch
from
EC-89-Universal-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...hantSDK/GiniMerchantSDKExample/GiniMerchantSDKExample/GiniMerchantSDKExample.entitlements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.developer.associated-domains</key> | ||
| <array> | ||
| <string>applinks:beaver-d97a1.web.app</string> | ||
| </array> | ||
| </dict> | ||
| </plist> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,26 +11,52 @@ import UIKit | |||||||||||||||||||||||||||||
| class AppDelegate: UIResponder, UIApplicationDelegate { | ||||||||||||||||||||||||||||||
| var window: UIWindow? | ||||||||||||||||||||||||||||||
| var coordinator: AppCoordinator! | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func application(_ application: UIApplication, | ||||||||||||||||||||||||||||||
| didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { | ||||||||||||||||||||||||||||||
| let window = UIWindow(frame: UIScreen.main.bounds) | ||||||||||||||||||||||||||||||
| coordinator = AppCoordinator(window: window) | ||||||||||||||||||||||||||||||
| coordinator.start() | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| return true | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func application(_ app: UIApplication, | ||||||||||||||||||||||||||||||
| open url: URL, | ||||||||||||||||||||||||||||||
| options: [UIApplication.OpenURLOptionsKey: Any] = [:]) -> Bool { | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| if (url.host == "payment-requester") { | ||||||||||||||||||||||||||||||
| coordinator.processBankUrl() | ||||||||||||||||||||||||||||||
| } else { | ||||||||||||||||||||||||||||||
| coordinator.processExternalDocument(withUrl: url, sourceApplication: options[.sourceApplication] as? String) | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| return true | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| func application(_ application: UIApplication, | ||||||||||||||||||||||||||||||
| continue userActivity: NSUserActivity, | ||||||||||||||||||||||||||||||
| restorationHandler: @escaping ([any UIUserActivityRestoring]?) -> Void) -> Bool { | ||||||||||||||||||||||||||||||
| // Get URL components from the incoming user activity. | ||||||||||||||||||||||||||||||
| guard userActivity.activityType == NSUserActivityTypeBrowsingWeb, | ||||||||||||||||||||||||||||||
| let incomingURL = userActivity.webpageURL, | ||||||||||||||||||||||||||||||
| let components = NSURLComponents(url: incomingURL, resolvingAgainstBaseURL: true), | ||||||||||||||||||||||||||||||
| let path = components.path, | ||||||||||||||||||||||||||||||
| let params = components.queryItems else { | ||||||||||||||||||||||||||||||
| print("❌ can't parse URL") | ||||||||||||||||||||||||||||||
| return false | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| // Validate URL components | ||||||||||||||||||||||||||||||
| guard components.host == "beaver-d97a1.web.app", | ||||||||||||||||||||||||||||||
| path == "/payment-requester", | ||||||||||||||||||||||||||||||
|
Comment on lines
+49
to
+50
|
||||||||||||||||||||||||||||||
| guard components.host == "beaver-d97a1.web.app", | |
| path == "/payment-requester", | |
| guard components.host == AppDelegate.HOST, | |
| path == AppDelegate.PAYMENT_REQUESTER_PATH, |
Comment on lines
+51
to
+57
Copilot
AI
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code checks that paymentRequestId exists but never retrieves its value or passes it to the coordinator. Extract the paymentRequestId from params and pass it into coordinator.processBankUrl(paymentRequestId:) (or a similar API) so the correct request is handled.
Suggested change
| params.first(where: { $0.name == "paymentRequestId" }) != nil else { | |
| print("❌ unsupported URL") | |
| return false | |
| } | |
| // Process URL | |
| coordinator.processBankUrl() | |
| let paymentRequestId = params.first(where: { $0.name == "paymentRequestId" })?.value else { | |
| print("❌ unsupported URL") | |
| return false | |
| } | |
| // Process URL | |
| coordinator.processBankUrl(paymentRequestId: paymentRequestId) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using
printfor error logging can be unreliable in production. Consider using a structured logging framework likeos_logor a custom logger to capture and categorize these events.