Technique: Correction d'une regression apportée par #5541#5556
Merged
Conversation
rsebille
reviewed
Feb 6, 2025
Contributor
rsebille
left a comment
There was a problem hiding this comment.
Le changement dans les tests me fait dire qu'effectivement maintenant on teste le cas mais j'ai du mal à comprendre le self.steps.current == self.steps.first qui me semble ultra-spécifique, j'ai l'impression qu'avec ça on ne gère pas le cas où la personne passe la 1ère étape d'un wizard et essaye ensuite d'aller à une étape suivante.
Contributor
Author
|
Damn... en fait il y a 2 problèmes
|
Contributor
|
🍿 Moi j'ai mon avis sur les wizard formtools 🧌 |
e3183ec to
f1d63fe
Compare
Contributor
Author
|
@rsebille j'ai améliorer le code pour mieux gérer les cas. |
rsebille
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Correction de #5541 (https://inclusion.sentry.io/issues/28983753/?project=4508410589020240)
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran