Skip to content

feat: 0.4.0 for GitExtensions 6.0 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: 0.4.0 for GitExtensions 6.0 #33

wants to merge 3 commits into from

Conversation

gerhardol
Copy link
Member

Is this needed for plugins?

@gerhardol gerhardol requested a review from RussKie August 16, 2025 21:23
@gerhardol gerhardol changed the title feat: 0.4.0 fir GitExtensions 6.0 feat: 0.4.0 for GitExtensions 6.0 Aug 16, 2025
@RussKie
Copy link
Member

RussKie commented Aug 17, 2025

I don't know, tbh. It doesn't look like there are any coupling to a specific version of GE.
So, probably, not neeeded?

@gerhardol gerhardol changed the title feat: 0.4.0 for GitExtensions 6.0 feat: 0.3.3 for GitExtensions 6.0 Aug 17, 2025
@gerhardol
Copy link
Member Author

I now realizes what this does, it packages GitExtensions.Extensibility from master.
This was not done at all for the 5.x releases, even if there were some bigger changes from 4.2.1 -5.x
Much fewer changes from 5.2.1 to 6.0.0, but I get a Gerrit popup due to to changed interfaces.

Some plugins uses [0.3-0.4)
I would say this a bugfix release

Maybe including the following too?
gitextensions/gitextensions#12469

@RussKie
Copy link
Member

RussKie commented Aug 19, 2025

Sounds good

@maraf
Copy link
Member

maraf commented Aug 19, 2025

I don't know, tbh. It doesn't look like there are any coupling to a specific version of GE.

The coupling is in https://github.com/gitextensions/gitextensions.pluginmanager/blob/master/src/GitExtensions.PluginManager/Plugin.cs#L55.

The idea is that by selecting minimal version, we limit plugins targeting the version. In other words, ideally we should SemVer (or to simplify things follow Git Extensions version) this package to be able to filter-out plugin targeting older, possibly incompatible, version of Git Extensions

@maraf
Copy link
Member

maraf commented Aug 19, 2025

If 6.0 is next major release, we should bump this package to 0.4.0 and update the version in Plugin.cs to 0.4.0 as well, to follow the pattern from previous releases.

@gerhardol
Copy link
Member Author

If 6.0 is next major release, we should bump this package to 0.4.0 and update the version in Plugin.cs to 0.4.0 as well, to follow the pattern from previous releases.

There were no update at all for GE5 and there are quite few changes in GE6. So apps that use 0.3 often works. At least Gerrit plugin will require a recompile with new version.
But from a strict SemVer perspective, the minor version need to be updated too.

@gerhardol
Copy link
Member Author

The PRs in milestone for 6.0.0 is now merged, this should be merged so plugins can be prepared

@maraf
Copy link
Member

maraf commented Aug 20, 2025

If Git Extensions V6 are "backward compatible" with existing plugins, we don't need to bump anything.

@gerhardol
Copy link
Member Author

If Git Extensions V6 are "backward compatible" with existing plugins, we don't need to bump anything.

GE 5 did more changes, but the ext version was not changed. No reported problems.
GE 6 makes less changes, but at least one change requires changes in the Gerrit plugin so a new version is required.

It depends on the plugins how the change hits them. I would assume most are compatible with GE4/GE5. If ext version is changed they could stop working.

But we could set version to 0.4 and require plugin updates.

@maraf
Copy link
Member

maraf commented Aug 20, 2025

I agree with 0.4

@gerhardol gerhardol changed the title feat: 0.3.3 for GitExtensions 6.0 feat: 0.4.0 for GitExtensions 6.0 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants