Wip/qmonet/frr reload (rebased) #428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fredi-raspall
force-pushed
the
pr/fredi/management-frr
branch
from
c392a3e to
cb6ee57
Compare
Fredi-raspall
force-pushed
the
wip/qmonet/frr_reload_relocated
branch
from
ead06f8 to
ed4dd0c
Compare
|
Fredi-raspall
force-pushed
the
pr/fredi/management-frr
branch
from
cb6ee57 to
e22e1bd
Compare
Add a wrapper to run the frr_reload.py Python script, necessary to test then reload FRR's configuration. When running the script, we collect the standard output and error, and the return code. Any data printed to stderr, or non-zero return code, means that the script hasn't executed as expected, and that the wrapper returns an error. Signed-off-by: Quentin Monnet <[email protected]>
We cannot call bash scripts from the test runner, because the image does not contain a bash interpreter. Use binaries (from C programs) instead. Signed-off-by: Quentin Monnet <[email protected]>
Signed-off-by: Fredi Raspall <[email protected]>
Fredi-raspall
force-pushed
the
wip/qmonet/frr_reload_relocated
branch
from
ed4dd0c to
880a2f1
Compare
|
|
Closing this since we will use the frr-agent instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@qmonnet I've rebased your branch on #396
and moved the code to the frr-reload specific submodule.