Skip to content

minor fixups #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2025
Merged

minor fixups #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
404e7af
fix(envrc): remove standalone -g flag causing rustdoc failures
daniel-noland Oct 14, 2025
fc22cc4
style(nextest): reorder test-groups table to satisfy linter
daniel-noland Oct 14, 2025
e1df741
chore(codebook): add ethtool and sysfs to spell-check dictionary
daniel-noland Oct 14, 2025
4ee9120
fix(deps): pin dplane-rpc to commit SHA instead of version
daniel-noland Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .config/nextest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,6 @@ store-success-output = true
# <description> element.
store-failure-output = true

[test-groups]
vm = { max-threads = 1 }

# [[profile.default.overrides]]
# filter = 'test(flaky test name here)'
# retries = 3
Expand All @@ -143,3 +140,6 @@ vm = { max-threads = 1 }
filter = 'package(dataplane)'
platform = 'cfg(unix)'
test-group = 'vm'

[test-groups]
vm = { max-threads = 1 }
2 changes: 1 addition & 1 deletion .envrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ fi
export NEXTEST_EXPERIMENTAL_LIBTEST_JSON=1

CRT="-C target-feature=-crt-static"
DEBUG="-g -C debuginfo=full -C split-debuginfo=off -C dwarf-version=5"
DEBUG="-C debuginfo=full -C split-debuginfo=off -C dwarf-version=5"
LINKER="-C linker=${COMPILE_ENV}/bin/clang -C link-arg=--ld-path=${COMPILE_ENV}/bin/ld.lld"
RELRO="-C relro-level=full"
TARGET_CPU="-C target-cpu=x86-64-v3"
Expand Down
140 changes: 33 additions & 107 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ config = { path = "./config", package = "dataplane-config" }
dpdk = { path = "./dpdk", package = "dataplane-dpdk" }
dpdk-sys = { path = "./dpdk-sys", package = "dataplane-dpdk-sys" }
dpdk-sysroot-helper = { path = "./dpdk-sysroot-helper", package = "dataplane-dpdk-sysroot-helper" }
dplane-rpc = { git = "https://github.com/githedgehog/dplane-rpc.git", version = "1.1.2" }
dplane-rpc = { git = "https://github.com/githedgehog/dplane-rpc.git", rev = "e8fc33db10e1d00785f2a2b90cbadcad7900f200" }
errno = { path = "./errno", package = "dataplane-errno" }
flow-info = { path = "./flow-info", package = "dataplane-flow-info" }
gateway_config = { git = "https://github.com/githedgehog/gateway-proto", tag = "v0.15.0" }
Expand Down
2 changes: 2 additions & 0 deletions codebook.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ words = [
"efa",
"eprintln",
"errno",
"ethtool",
Copy link
Member

@qmonnet qmonnet Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How comes this didn't show up earlier? Are we not running the spell checker in CI? 🤔

Copy link
Collaborator Author

@daniel-noland daniel-noland Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just happened to see that the spell check was flagging ethtool. Does the spell check pose a problem?

Copy link
Member

@qmonnet qmonnet Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I was simply realising and wondering why we don't run it in CI, to make sure that we don't introduce spelling mistakes with new PRs. ethtool, for example, was introduced in a previous PR but was not added to the spelling list, although it should have.

"ffff",
"fredi",
"frr",
Expand Down Expand Up @@ -85,6 +86,7 @@ words = [
"smt",
"subdevice",
"subvendor",
"sysfs",
"tailroom",
"tctl",
"tdebug",
Expand Down
Loading