Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the execSync result for debugging #15

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

ashishkeshan
Copy link
Contributor

@ashishkeshan ashishkeshan commented Mar 27, 2024

Send the results of the execSync calls to the console for easier debugging. This came up due to: https://github.com/orgs/community/discussions/106545#discussioncomment-8893352. It would have been an easy fix for the teacher if we had surfaced that it was failing because gdown was not installed.

@ashishkeshan ashishkeshan marked this pull request as ready for review March 27, 2024 17:01
@ashishkeshan ashishkeshan requested a review from a team as a code owner March 27, 2024 17:01
Copy link

@JessRudder JessRudder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change the output the students are going to see? Will it make it more confusing for them?

I'm assuming we need this regardless for debugging purposes but am hopeful the student-facing impact is minimal.

@ashishkeshan
Copy link
Contributor Author

Student facing impact will be minimal because the relevant output for them will be in the Reporter step. This will just provide output inside the Command Grader step which is what does the setup command and the run command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants