Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundled copy of actions extractor #2787

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th

## [UNRELEASED]

No user facing changes.
- The CodeQL Action no longer includes its own copy of the extractor for the `actions` language, which is currently in public preview.
The `actions` extractor has been included in the CodeQL CLI since v2.20.4. If your workflow has enabled the `actions` language _and_ you have pinned
your `tools:` property to a specific version of the CodeQL CLI earlier than v2.20.4, you will need to update to at least CodeQL v2.20.4 or disable
`actions` analysis.

## 3.28.13 - 24 Mar 2025

Expand Down
44 changes: 0 additions & 44 deletions actions-extractor/codeql-extractor.yml

This file was deleted.

40 changes: 0 additions & 40 deletions actions-extractor/tools/autobuild-impl.ps1

This file was deleted.

3 changes: 0 additions & 3 deletions actions-extractor/tools/autobuild.cmd

This file was deleted.

39 changes: 0 additions & 39 deletions actions-extractor/tools/autobuild.sh

This file was deleted.

14 changes: 0 additions & 14 deletions lib/codeql.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.js.map

Large diffs are not rendered by default.

14 changes: 0 additions & 14 deletions src/codeql.ts
Original file line number Diff line number Diff line change
Expand Up @@ -570,20 +570,6 @@ export async function getCodeQLForCmd(
extraArgs.push(`--trace-process-name=${processName}`);
}

if (config.languages.indexOf(Language.actions) >= 0) {
// We originally added an embedded version of the Actions extractor to the CodeQL Action
// itself in order to deploy the extractor between CodeQL releases. When we did add the
// extractor to the CLI, though, its autobuild script was missing the execute bit.
// 2.20.6 is the first CLI release with the fully-functional extractor in the CLI. For older
// versions, we'll keep using the embedded extractor. We can remove the embedded extractor
// once 2.20.6 is deployed in the runner images.
if (!(await util.codeQlVersionAtLeast(codeql, "2.20.6"))) {
extraArgs.push("--search-path");
const extractorPath = path.resolve(__dirname, "../actions-extractor");
extraArgs.push(extractorPath);
}
}

const codeScanningConfigFile = await generateCodeScanningConfig(
config,
logger,
Expand Down
Loading