Merge releases/v4 into releases/v3 #3314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mergeback v4.31.3 refs/heads/releases/v4 into main
…riction Overlay: Remove repository owner restriction
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…4.1.1 Bump js-yaml from 4.1.0 to 4.1.1
This reverts commit 023fd08.
Bumps the actions-minor group with 1 update in the /.github/workflows directory: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.267.0 to 1.268.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@d5126b9...8aeb6ff) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.268.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Change v3 deprecation message to warning.
…thub/workflows/actions-minor-761b22fa12 Bump ruby/setup-ruby from 1.267.0 to 1.268.0 in /.github/workflows in the actions-minor group across 1 directory
Add additional options to PR template and clarify some
Bump `glob` to at least `11.1.0`
Merge main into releases/v4
This reverts commit c5a9d29.
This reverts commit e5971bd.
henrymercer
added
Rebuild
Contributor
Author
|
Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a release PR that merges changes from releases/v4 into releases/v3, bumping the version from 3.31.3 to 3.31.4. According to the custom coding guidelines, this is a release-PR and only CHANGELOG.md and package.json should be reviewed. The PR includes dependency updates (js-yaml, glob) and corresponding changes to generated code in the lib/ directory, which are expected and do not require review per the guidelines.
Reviewed Changes
Copilot reviewed 16 out of 22 changed files in this pull request and generated 45 comments.
| File | Description |
|---|---|
| CHANGELOG.md | Adds entry for version 3.31.4 with release date |
| package.json | Updates version to 3.31.4 and dependency versions |
| lib/*.js | Generated JavaScript files (not reviewed per guidelines) |
| Other files | Workflows, config files (not reviewed per guidelines) |
| return error4 instanceof ConfigurationError ? "user-error" : "failure"; | ||
| function getActionsStatus(error3, otherFailureCause) { | ||
| if (error3 || otherFailureCause) { | ||
| return error3 instanceof ConfigurationError ? "user-error" : "failure"; |
There was a problem hiding this comment.
This expression will be implicitly converted from undefined to object.
| const flatResponse = (0, utils_js_1.flattenResponse)(rawResponse, operationSpec.responses[error4.statusCode] || operationSpec.responses["default"]); | ||
| error4.details = flatResponse; | ||
| } catch (error3) { | ||
| if (typeof error3 === "object" && (error3 === null || error3 === void 0 ? void 0 : error3.response)) { |
There was a problem hiding this comment.
This guard always evaluates to false.
| const flatResponse = (0, utils_js_1.flattenResponse)(rawResponse, operationSpec.responses[error4.statusCode] || operationSpec.responses["default"]); | ||
| error4.details = flatResponse; | ||
| } catch (error3) { | ||
| if (typeof error3 === "object" && (error3 === null || error3 === void 0 ? void 0 : error3.response)) { |
There was a problem hiding this comment.
This guard always evaluates to false.
| const flatResponse = (0, utils_js_1.flattenResponse)(rawResponse, operationSpec.responses[error4.statusCode] || operationSpec.responses["default"]); | ||
| error4.details = flatResponse; | ||
| } catch (error3) { | ||
| if (typeof error3 === "object" && (error3 === null || error3 === void 0 ? void 0 : error3.response)) { |
There was a problem hiding this comment.
This guard always evaluates to false.
| logger.info(`RetryPolicy: Network error ${retriableError} found, will retry.`); | ||
| return true; | ||
| } | ||
| } | ||
| if ((error4 === null || error4 === void 0 ? void 0 : error4.code) === "PARSE_ERROR" && (error4 === null || error4 === void 0 ? void 0 : error4.message.startsWith(`Error "Error: Unclosed root tag`))) { | ||
| if ((error3 === null || error3 === void 0 ? void 0 : error3.code) === "PARSE_ERROR" && (error3 === null || error3 === void 0 ? void 0 : error3.message.startsWith(`Error "Error: Unclosed root tag`))) { |
There was a problem hiding this comment.
This guard always evaluates to false.
| logger.info(`RetryPolicy: Network error ${retriableError} found, will retry.`); | ||
| return true; | ||
| } | ||
| } | ||
| if ((error4 === null || error4 === void 0 ? void 0 : error4.code) === "PARSE_ERROR" && (error4 === null || error4 === void 0 ? void 0 : error4.message.startsWith(`Error "Error: Unclosed root tag`))) { | ||
| if ((error3 === null || error3 === void 0 ? void 0 : error3.code) === "PARSE_ERROR" && (error3 === null || error3 === void 0 ? void 0 : error3.message.startsWith(`Error "Error: Unclosed root tag`))) { |
There was a problem hiding this comment.
This guard always evaluates to false.
| @@ -48838,24 +48839,24 @@ var require_dist_node15 = __commonJS({ | |||
| }); | |||
| module2.exports = __toCommonJS2(dist_src_exports); | |||
| var import_core = require_dist_node11(); | |||
There was a problem hiding this comment.
Unused variable import_core.
| } else { | ||
| object[key] = value; | ||
| } | ||
| } | ||
| var simpleEscapeCheck = new Array(256); | ||
| var simpleEscapeMap = new Array(256); | ||
| for (i = 0; i < 256; i++) { |
There was a problem hiding this comment.
Variable 'i' is used before its declaration.
| if (error4 || otherFailureCause) { | ||
| return error4 instanceof ConfigurationError ? "user-error" : "failure"; | ||
| function getActionsStatus(error3, otherFailureCause) { | ||
| if (error3 || otherFailureCause) { |
There was a problem hiding this comment.
This expression always evaluates to false.
henrymercer
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging e12f017 into
releases/v3.Conductor for this PR is @mbg.
Contains the following pull requests:
globto at least11.1.0#3311 (@mbg)Please do the following:
releases/v3branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.