CodeQL: Update test results after array specifier bug fix in the extractor #885
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts test results and comments in the CodeQL test suite after a bug fix, ensuring that the tests accurately reflect the now-verified behavior.
- Removed the outdated workaround with a false-positive comment in test_array_uses_static_again
- Updated test comments so that all tests uniformly indicate COMPLIANT results
Files not reviewed (1)
- c/misra/test/rules/RULE-17-6/UseOfArrayStatic.expected: Language not supported
Comments suppressed due to low confidence (1)
c/misra/test/rules/RULE-17-6/test.c:4
- Consider adding a comment explaining that the workaround was removed because the underlying CodeQL bug has been fixed; this will help future maintainers understand the context of the COMPLIANT designation.
void test_array_uses_static_again(int arr4[11]) {} // COMPLIANT
jketema
changed the title
jketema
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.