Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calumgrant/bmn/uninitialized local #17481

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Calumgrant/bmn/uninitialized local #17481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
235275a
C++: Skip results from cpp/uninitialised-local on errors
calumgrant Sep 16, 2024
5a3ff1e
C++: Fix FPs in cpp/uninitialized-local
calumgrant Sep 16, 2024
2ee56cd
C++: Format C++ file
calumgrant Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/ql/src/Likely Bugs/Memory Management/UninitializedLocal.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,6 @@ from
where
conf.hasFlowPath(source, sink) and
isSinkImpl(sink.getInstruction(), va) and
v = va.getTarget()
v = va.getTarget() and
not exists(ErrorExpr e | e.getEnclosingFunction() = v.getFunction())
select va, source, sink, "The variable $@ may not be initialized at this access.", v, v.getName()
4 changes: 4 additions & 0 deletions cpp/ql/test/query-tests/Security/CWE/CWE-457/semmle/Errors/UninitializedLocal.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
edges
nodes
| test.cpp:4:7:4:7 | definition of x | semmle.label | definition of x |
#select
1 change: 1 addition & 0 deletions cpp/ql/test/query-tests/Security/CWE/CWE-457/semmle/Errors/UninitializedLocal.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Likely Bugs/Memory Management/UninitializedLocal.ql
7 changes: 7 additions & 0 deletions cpp/ql/test/query-tests/Security/CWE/CWE-457/semmle/Errors/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// semmle-extractor-options: --expect_errors

int f() {
int x;
initialize(&x); // error expression - initialize() is not defined
return x; // GOOD - assume x is initialized
}
Loading