Rust: ast-based extractor #17502
Merged
Rust: ast-based extractor #17502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
aibaars
force-pushed
the
aibaars/rust-extract-ast
branch
9 times, most recently
from
fce5d6b
to
0ae8d33
Compare
aibaars
force-pushed
the
aibaars/rust-extract-ast
branch
from
0ae8d33
to
ecc69dc
Compare
aibaars
force-pushed
the
aibaars/rust-extract-ast
branch
from
ecc69dc
to
23d2e03
Compare
redsun82
reviewed
Sep 19, 2024
There was a problem hiding this comment.
for follow-up: we can pull in this file with bazel instead of checking it in
|
The go failures are probably being handled by #17513 if I got it right |
aibaars
force-pushed
the
aibaars/rust-extract-ast
branch
from
ebd0d2f
to
4a19902
Compare
aibaars
force-pushed
the
aibaars/rust-extract-ast
branch
from
4a19902
to
cad6e6a
Compare
aibaars
force-pushed
the
aibaars/rust-extract-ast
branch
from
cad6e6a
to
3aa47a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request rewrites the Rust extractor to extract the AST nodes of rust-analyzer instead the HIR nodes. The implementation is generated from the
rust.ungramsyntax definition.