C#/Java: Re-factor the model generator to be a parameterized module. #17509
+1,401
−1,941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
modelgen/parammodule
branch
from
12b2877
to
75508d6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| kind = DataFlowImplCommon::getValueReturnPosition(this).getKind() or | ||
| kind = DataFlowImplCommon::getParamReturnPosition(this, _).getKind() | ||
| } | ||
| private import csharp as CS |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
| private import CaptureModelsSpecific | ||
| private import CaptureModelsPrinting | ||
| private import java as J | ||
| private import semmle.code.java.dataflow.DataFlow |
Check warning
Code scanning / CodeQL
Redundant import Warning
| private import semmle.code.java.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl | ||
| private import semmle.code.java.dataflow.internal.ModelExclusions | ||
| private import semmle.code.java.dataflow.internal.TaintTrackingImplSpecific | ||
| private import semmle.code.java.dataflow.SSA as Ssa |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
| */ | ||
|
|
||
| private import codeql.dataflow.DataFlow | ||
| private import codeql.dataflow.TaintTracking as Tt |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
michaelnebel
force-pushed
the
modelgen/parammodule
branch
2 times, most recently
from
117287d
to
d09948f
Compare
michaelnebel
changed the title
michaelnebel
force-pushed
the
modelgen/parammodule
branch
from
d09948f
to
faf6fea
Compare
michaelnebel
force-pushed
the
modelgen/parammodule
branch
from
faf6fea
to
f142af5
Compare
michaelnebel
added
the
no-change-note-required
|
DCA looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we replace the "pyrameterised" module of the model generator with a parameterised module.
The comments used in the signature module are mostly taken from the C#/Java specific implementation.