Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions queries to generated list #18519

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dbartol
Copy link
Contributor

@dbartol dbartol commented Jan 16, 2025

This PR adds actions to the list of languages to include in the code scanning query list. We generate these lists for each release for various purposes.

@Copilot Copilot bot review requested due to automatic review settings January 16, 2025 23:04
@dbartol dbartol requested a review from RasmusWL as a code owner January 16, 2025 23:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

marcogario
marcogario previously approved these changes Jan 17, 2025
@RasmusWL
Copy link
Member

Workflow failed with this message:

A fatal error occurred: actions-security-experimental.qls is not a .ql file, .qls file, a directory, or a query pack specification.

So it seems like the actions queries are not providing the expected query suites used by this tool.

Do you want to changes to the query-suites to conform? otherwise I guess we could change the tool to accept missing .qls files

Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️

@dbartol dbartol requested a review from a team as a code owner January 17, 2025 14:48
@github-actions github-actions bot added the Actions Analysis of GitHub Actions label Jan 17, 2025
@dbartol
Copy link
Contributor Author

dbartol commented Jan 17, 2025

@RasmusWL I've added the actions-security-experimental.qls suite, which just imports actions-code-scanning.qls. That's exactly what all of the other Actions suites do for now, so it seemed reasonable to add the missing "standard" suite the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants