Upgrade workflows to ubuntu-24 #18525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (6)
- .devcontainer/swift/Dockerfile: Language not supported
- csharp/ql/integration-tests/all-platforms/autobuild/autobuild.csproj: Language not supported
- csharp/ql/integration-tests/all-platforms/autobuild/global.json: Language not supported
- .github/workflows/swift.yml: Evaluated as low risk
- actions/ql/test/query-tests/Security/CWE-094/.github/workflows/self_needs.yml: Evaluated as low risk
- actions/ql/test/query-tests/Security/CWE-094/.github/workflows/test10.yml: Evaluated as low risk
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
oscarsj
commented
Jan 17, 2025
Comment on lines
-51
to
-56
| build-and-test-linux: | ||
| if: github.repository_owner == 'github' | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: ./swift/actions/build-and-test |
There was a problem hiding this comment.
swift not supported on ubuntu-24, so dropping this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes in queries.
runs-onlabels to update toubuntu-24.ImplicitUsingslabel removed from target framework (suggested in https://stackoverflow.com/questions/70722475/error-cs8773-feature-global-using-directive-is-not-available-in-c-sharp-9-0) since that label is not available in .Net5 for C# 9 and was failing here https://github.com/github/semmle-code/actions/runs/12827227794