Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18629 we fixed a source of FPs in buffer-overflow queries that look like:
In order to compute the size of the buffer starting at
c
we compute the size of the "base" (in this caseA
) and subtract that from how far "we've gone" through the object.This works fine on the above example, but when the code looks like:
we need to strip the pointer off
a
in order to get theClass
type.We already have tests that would have caught this, but CI didn't run on #18629 which is why it was missed