Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: update rust-analyzer from 0.0.266 to 0.0.270 #19083

Merged
merged 14 commits into from
Mar 28, 2025

Conversation

redsun82
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Mar 20, 2025
@redsun82 redsun82 marked this pull request as ready for review March 21, 2025 15:45
@redsun82 redsun82 requested a review from a team as a code owner March 21, 2025 15:45
@redsun82
Copy link
Contributor Author

As far as I can tell the first DCA experiment is showing several changes on the rust-analyzer comparison side that I'll let @hvitved look into. There were also 2 reops failing because of some infrastructure blip. I've restarted another one with those two repos.

@hvitved
Copy link
Contributor

hvitved commented Mar 23, 2025

As far as I can tell the first DCA experiment is showing several changes on the rust-analyzer comparison side that I'll let @hvitved look into.

When we look at the Rust-analyzer comparison, call graph (QL unique), per source numbers, it goes up by ~20k, which means that our QL implementation is able to resolve an additional 20k calls that the extractor cannot. However, looking at the numbers for Rust-analyzer comparison, call graph (same), per source, we see that it goes down by ~20k as well, so this means that our QL implementation is not actually able to resolve any new calls, it simply means that the extractor is able to resolve 20k fewer calls. The same goes for the path-resolution numbers. So, in summary, the upgrade makes the extractor-provided resolution data less precise, which I reckon is because we cannot provide meaningful canonical paths for anonymous items anymore?

@redsun82
Copy link
Contributor Author

which I reckon is because we cannot provide meaningful canonical paths for anonymous items anymore?

Indeed, that seems the case.

@redsun82 redsun82 changed the title Rust: update rust-analyzer Rust: update rust-analyzer from 0.0.266 to 0.0.270 Mar 24, 2025
aibaars
aibaars previously approved these changes Mar 28, 2025
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, unfortunately a conflict.

@redsun82 redsun82 merged commit 96f7dc7 into main Mar 28, 2025
56 checks passed
@redsun82 redsun82 deleted the redsun82/rust-analyzer-update branch March 28, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants