C++: Add support for getting literals in using declarations #19603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrissRio
added
the
depends on internal PR
IdrissRio
force-pushed
the
idrissrio/comments-using
branch
from
ff24105 to
20edf34
Compare
IdrissRio
changed the title
IdrissRio
force-pushed
the
idrissrio/comments-using
branch
from
20edf34 to
b322892
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds the ability to retrieve the specific member referenced by a using declaration in a templated base class and updates toString() to fall back to this new API.
- Introduces
getReferencedMember()inUsingDeclarationEntry. - Modifies
toString()to usegetDeclaration()first orgetReferencedMember()as a fallback. - Documents the feature in a new change-notes entry.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/ql/lib/semmle/code/cpp/Namespace.qll | Added getReferencedMember() and updated toString() |
| cpp/ql/lib/change-notes/2025-05-28-using-template.md | Added feature note for getReferencedMember |
Comments suppressed due to low confidence (2)
cpp/ql/lib/semmle/code/cpp/Namespace.qll:191
- The use of
orbetween two assignment statements here is invalid syntax and won't produce the intended fallback behavior. Consider computing both descriptions first or use a conditional expression to assign a singleresultvalue.
result = "using " + this.getDeclaration().getDescription() or
cpp/ql/lib/semmle/code/cpp/Namespace.qll:192
getReferencedMember()returns anElement, not astring. You need to call its.getDescription()(or equivalent) to produce a textual representation.
result = "using " + this.getReferencedMember()
geoffw0
reviewed
May 30, 2025
| * }; | ||
| * ``` | ||
| */ | ||
| Element getReferencedMember() { usings(underlyingElement(this), unresolveElement(result), _, _) } |
There was a problem hiding this comment.
Please could we have a test for this somewhere.
There was a problem hiding this comment.
Good point! I'll do that. Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.