Java: Make virtual dispatch global while keeping ssa local. #20271
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexet
force-pushed
the
alexet/ssa-global
branch
from
9f5fd01 to
2707be3
Compare
alexet
force-pushed
the
alexet/ssa-global
branch
from
2707be3 to
24b6903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of FPs caused by local virtual dispatch while keeping the majority of SSA computation global.
I'm not sure what the naming convention of the internal predicates for global computation that we force local should be. I originally went for
Impl, but then one of them was alreadyImplandImplImplis silly. So that one was suffixed withGlobal.