Skip to content

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Oct 3, 2025

Currently no one is added as a reviewer, except in the /shared/quantum/ subfolder.

Talking points:

  • Is it worth setting up some kind of team for this? I see that was done for ql-for-ql.
  • Does anyone else want to be added? @MathiasVP maybe?

@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 09:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds code ownership for the /shared/ directory by assigning three specific reviewers as code owners. This addresses the current gap where no reviewers are automatically assigned for changes in the /shared/ directory (except for the /shared/quantum/ subfolder).

Key Changes

  • Adds code ownership assignment for /shared/ directory to ensure automatic reviewer assignment

@nicolaswill
Copy link
Contributor

nicolaswill commented Oct 6, 2025

The code in /shared/quantum/ is/should be owned by my team, @github/ps-codeql. I am the primary maintainer along with @bdrodes. It would be helpful for ongoing development to keep us as the code owner for that subdirectory. (edited for clarity)

@owen-mc
Copy link
Contributor Author

owen-mc commented Oct 7, 2025

@nicolaswill Yes, I have left the line related to that and my understanding is that because it is more specific lower down, it will override the rule I am adding for /shared/. (That's what copilot told me...)

@owen-mc owen-mc changed the title Add code owners for /shared/ Add code owners for /shared/ and a catch-all Oct 7, 2025
@owen-mc
Copy link
Contributor Author

owen-mc commented Oct 7, 2025

I have created the team github/codeql-shared-libraries-reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants