Skip to content

Add code owners for /shared/ and a catch-all #20580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2025
Merged

Add code owners for /shared/ and a catch-all #20580

merged 5 commits into from
Oct 9, 2025

Conversation

@owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Oct 3, 2025 •
edited
Loading

Currently no one is added as a reviewer, except in the /shared/quantum/ subfolder. I've made a new team github/codeql-shared-libraries-reviewers for this purpose, and added myself and two other volunteers to it.

Also, there is no catch-all. That is, if none of the rules match, then no one will be tagged as a reviewer. I have added the existing team github/codeql-alert-coverage-eng in this role. The catch-all has to be put at the top of the file because the last line which matches a file has precedence.

Copilot AI review requested due to automatic review settings October 3, 2025 09:43
Copilot AI reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds code ownership for the /shared/ directory by assigning three specific reviewers as code owners. This addresses the current gap where no reviewers are automatically assigned for changes in the /shared/ directory (except for the /shared/quantum/ subfolder).

Key Changes

  • Adds code ownership assignment for /shared/ directory to ensure automatic reviewer assignment

@nicolaswill
Copy link
Contributor

nicolaswill commented Oct 6, 2025 •
edited
Loading

The code in /shared/quantum/ is/should be owned by my team, @github/ps-codeql. I am the primary maintainer along with @bdrodes. It would be helpful for ongoing development to keep us as the code owner for that subdirectory. (edited for clarity)

@owen-mc
Copy link
Contributor Author

owen-mc commented Oct 7, 2025 •
edited
Loading

@nicolaswill Yes, I have left the line related to that and my understanding is that because it is more specific lower down, it will override the rule I am adding for /shared/. (That's what copilot told me...)

@owen-mc owen-mc changed the title Add code owners for /shared/ Add code owners for /shared/ and a catch-all Oct 7, 2025
@owen-mc
Copy link
Contributor Author

owen-mc commented Oct 7, 2025

I have created the team github/codeql-shared-libraries-reviewers.

@owen-mc owen-mc requested a review from a team October 8, 2025 13:40
@owen-mc owen-mc merged commit 2c6af0c into github:main Oct 9, 2025
7 checks passed
@owen-mc owen-mc deleted the codeowners-for-shared-libs-and-catchall branch October 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mbg mbg mbg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@owen-mc @nicolaswill @mbg