Java: Recognize int-sized long literals. #20886
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
Copilot finished reviewing on behalf of
aschackmull
November 21, 2025 11:56
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the constantIntegerExpr predicate in the Java range analysis utilities to recognize long literals that fit within the integer range. The change addresses feedback from a previous pull request by adding support for LongLiteral values that can be safely converted to int.
Key Changes
- Added a new disjunct to the
constantIntegerExprpredicate to handleLongLiteralexpressions whose values fit in anint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
owen-mc
approved these changes
Nov 21, 2025
Contributor
owen-mc
left a comment
owen-mc
left a comment
There was a problem hiding this comment.
I see that string.toInt() has no value if the value is outside of the range of an int, so this seems good. I have confirmed that this fixes the case that prompted this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in response to #20741 (comment)