Unified: Type inference for nested types by hvitved · Pull Request #22866 · github/codeql

hvitved · 2026-10-21T13:47:27Z

No description provided.

Copilot

🟡 Changes recommended

Implicit argument handling and parent-scope checks still produce incorrect or incomplete nested-type inference.

2 open issues

What changed in this PR

Extends Unified’s type inference to represent nested types and preserve their enclosing generic arguments, with Swift regression coverage.

Changes:

Adds parent-type parameters and qualified type names.
Updates type mentions and enum construction to propagate parent-type paths.
Adds nested-type tests and updates inference expectations.

File	Description
`unified/ql/test/library-tests/type-inference/type-inference.expected`	Updates expected inference results.
`unified/ql/test/library-tests/type-inference/nested_types.swift`	Adds nested-generic, self-type, and extension coverage.
`unified/ql/test/library-tests/type-inference/generics.swift`	Removes a resolved `MISSING` annotation.
`unified/ql/test/library-tests/type-inference/classes.swift`	Updates the inline expected nested-type name.
`unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll`	Adds nested-type qualification and implicit argument handling.
`unified/ql/lib/codeql/unified/internal/typeinference/TypeInferencePluginSwift.qll`	Removes Swift-specific enum plugin hooks.
`unified/ql/lib/codeql/unified/internal/typeinference/TypeInferencePlugin.qll`	Removes enum-specific hooks and wrappers.
`unified/ql/lib/codeql/unified/internal/typeinference/TypeInference.qll`	Integrates parent paths into constructor inference.
`unified/ql/lib/codeql/unified/internal/typeinference/Type.qll`	Introduces parent-type parameters and qualified names.
`unified/ql/lib/codeql/unified/internal/AstExtra.qll`	Adds shared enum relationships and enum-field modeling.

_{Review effort: Max}

Copilot

🔵 Needs a closer look

Unresolved generic-inference regressions and changes to recursive type paths require fixes and human validation.

3 open issues

2 resolved since last review

_{Review effort: Max}

Copilot

🔵 Needs a closer look

Recursive generic substitution and constructor propagation have unresolved correctness concerns and need expert validation.

2 open issues

3 resolved since last review

_{Review effort: Max}

Copilot

🟡 Changes recommended

Parent-type inference can recurse into itself and produce conflicting types for nested classes and aliases.

7 open issues

2 resolved since last review

_{Review effort: Max}

Copilot

🟡 Changes recommended

Alias expansion can lose enclosing generic arguments or introduce conflicting certain types.

3 open issues

7 resolved since last review

_{Review effort: Max}

Copilot

🔵 Needs a closer look

The coupled changes to recursive type resolution, alias expansion, and constructor inference require expert human validation.

1 open issue

Narrow nested alias exclusion or document the inference limitation · New

4 resolved since last review

_{Review effort: Max}

Copilot

🔵 Needs a closer look

The coupled recursive inference changes retain a correctness defect and require human validation.

1 open issue

Restrict prefix matching to parent-type parameter paths · New

1 resolved since last review

Narrow nested alias exclusion or document the inference limitation

_{Review effort: Max}

Copilot

🟡 Changes recommended

Nested alias handling still loses qualifier information in forwarded references, generic arguments, and tuple elements, causing incorrect outer-type inference for qualified alias uses.

2 open issues

1 resolved since last review

Restrict prefix matching to parent-type parameter paths

_{Review effort: Max}

Copilot

🟡 Changes recommended

The enum-field inference rule misses generic arguments beneath parent paths, preventing nested enum initializers from acquiring outer type arguments from their annotations.

1 open issue

Infer missing outer type arguments for nested enum fields · New

2 resolved since last review

_{Review effort: Max}

Copilot

🟡 Changes recommended

The QLDoc references a nonexistent parameter, and test annotations contain internal issue URLs that external contributors cannot access.

2 open issues

1 resolved since last review

Infer missing outer type arguments for nested enum fields

_{Review effort: Max}

+ *
+ * The type path `pathParents` is any valid sequence of `ParentTypeParameterType`s starting
+ * from the alias declaration and not escaping `parent`, while `encl` is the enclosing
+ * class of the last element of `path`.


+var x7 = innerMost.getInner()  // $ target=Outer.Inner.InnerMost.getInner $ MISSING: type=x7:Int (https://github.com/github/codeql-team/issues/4968)
+var y7 = innerMost.getOuter()  // $ target=Outer.Inner.InnerMost.getOuter $ MISSING: type=y7:String (https://github.com/github/codeql-team/issues/4968)


github-actions Bot added the Unified label Oct 21, 2026

hvitved force-pushed the unified/type-inference-nested-types branch from 2c69161 to b14b51a Compare October 21, 2026 13:57

github-advanced-security Bot found potential problems Oct 21, 2026

View reviewed changes

Comment thread unified/ql/lib/utils/test/TestUtils.qll Fixed

hvitved force-pushed the unified/type-inference-nested-types branch 6 times, most recently from 03284cb to 0455baf Compare October 22, 2026 09:30

hvitved requested a max review from Copilot October 22, 2026 09:30

Copilot started reviewing on behalf of hvitved October 22, 2026 09:31

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

hvitved force-pushed the unified/type-inference-nested-types branch from 0455baf to e55b569 Compare October 22, 2026 13:31

hvitved requested a max review from Copilot October 22, 2026 13:32

Copilot started reviewing on behalf of hvitved October 22, 2026 13:33

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

hvitved requested a max review from Copilot October 22, 2026 20:13

Copilot started reviewing on behalf of hvitved October 22, 2026 20:14

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeInference.qll Resolved

hvitved force-pushed the unified/type-inference-nested-types branch 4 times, most recently from 606fac6 to fee52f9 Compare October 23, 2026 09:51

hvitved requested a max review from Copilot October 23, 2026 09:51

Copilot started reviewing on behalf of hvitved October 23, 2026 09:52

View session

Copilot AI reviewed Oct 23, 2026

View reviewed changes

hvitved force-pushed the unified/type-inference-nested-types branch from fee52f9 to a014cb6 Compare October 23, 2026 12:24

hvitved requested a max review from Copilot October 23, 2026 12:25

Copilot started reviewing on behalf of hvitved October 23, 2026 12:25

View session

Copilot AI reviewed Oct 23, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

hvitved force-pushed the unified/type-inference-nested-types branch from 9fbb278 to 92bdb7b Compare October 26, 2026 14:56

hvitved requested a max review from Copilot October 26, 2026 14:58

Copilot started reviewing on behalf of hvitved October 26, 2026 14:58

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

hvitved requested a max review from Copilot October 26, 2026 16:08

Copilot started reviewing on behalf of hvitved October 26, 2026 16:09

View session

github-advanced-security Bot found potential problems Oct 26, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Fixed

Copilot AI reviewed Oct 26, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

hvitved force-pushed the unified/type-inference-nested-types branch 3 times, most recently from 9a2da2f to f27b5df Compare October 29, 2026 19:32

github-advanced-security Bot found potential problems Oct 29, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Fixed

github-actions Bot added the Rust Pull requests that update Rust code label Oct 29, 2026

hvitved force-pushed the unified/type-inference-nested-types branch 2 times, most recently from 5ffdc62 to 16e479a Compare October 30, 2026 12:23

github-actions Bot removed the Rust Pull requests that update Rust code label Oct 30, 2026

hvitved force-pushed the unified/type-inference-nested-types branch from 16e479a to d259816 Compare October 30, 2026 12:34

hvitved requested a max review from Copilot October 30, 2026 12:51

Copilot started reviewing on behalf of hvitved October 30, 2026 12:52

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll Resolved

hvitved force-pushed the unified/type-inference-nested-types branch from d259816 to af6d3b3 Compare October 30, 2026 14:15

Unified: Type inference for nested types

cd773cb

hvitved force-pushed the unified/type-inference-nested-types branch from af6d3b3 to cd773cb Compare October 30, 2026 14:17

hvitved requested a max review from Copilot October 30, 2026 14:31

Copilot started reviewing on behalf of hvitved October 30, 2026 14:31

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread unified/ql/lib/codeql/unified/internal/typeinference/Type.qll Resolved

wip

12f09e4

hvitved requested a max review from Copilot October 30, 2026 16:35

Copilot started reviewing on behalf of hvitved October 30, 2026 16:35

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

		var x7 = innerMost.getInner() // $ target=Outer.Inner.InnerMost.getInner $ MISSING: type=x7:Int (https://github.com/github/codeql-team/issues/4968)
		var y7 = innerMost.getOuter() // $ target=Outer.Inner.InnerMost.getOuter $ MISSING: type=y7:String (https://github.com/github/codeql-team/issues/4968)

Conversation

hvitved commented Oct 21, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants