-
Notifications
You must be signed in to change notification settings - Fork 59.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes GHES docs for PAT as SSO not available #33695
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@amarvin Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks, @nguyenalex836! |
.../authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens.md
Show resolved
Hide resolved
Hi @amarvin, thanks for working on this, it looks like a really good change! Before we merge this, can I ask you to make one tiny change? Our style guide asks us not to include liquid conditionals in filenames, this can cause problems for a few automations we have. It won't look as neat but could you change this so we have two complete image tags? For example:
Let me know once you've made the change so I can review and get this merged! ✨ |
Great point and sorry for missing that in the style guide! I've made the change for you to review. |
@stevecat, this is ready for your review. |
nudge @stevecat |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
GitHub Enterprise Server (GHES) allows generating personal access tokens (PATs), but unlike GitHub Cloud or GitHub Enterprise Cloud (GHEC) there is no option in GHES to enable SAML SSO for PATs.
Closes: #33696
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.