Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added needed call of google-github-actions/auth with credentials and changed version of google-github-actions calls #34265

Closed
wants to merge 1 commit into from
Closed

Added needed call of google-github-actions/auth with credentials and changed version of google-github-actions calls #34265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...yment/deploying-to-your-cloud-provider/deploying-to-google-kubernetes-engine.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,13 @@ jobs:
- name: Checkout
uses: {% data reusables.actions.action-checkout %}

- name: Authenticate with Google Cloud
uses: google-github-actions/auth@v1 # or specify different version if available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: google-github-actions/auth@v1 # or specify different version if available
# uses: google-github-actions/auth@v2
uses: google-github-actions/auth@f112390a2df9932162083945e46d439060d66ec2 # v2.1.4

with:
credentials_json: ${{ secrets.GKE_SA_KEY }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work as demonstrated in previews, needs escaping:

Suggested change
credentials_json: ${{ secrets.GKE_SA_KEY }}
credentials_json: {% raw %}${{ secrets.GKE_SA_KEY }}{% endraw %}


# Setup gcloud CLI
- uses: google-github-actions/setup-gcloud@1bee7de035d65ec5da40a31f8589e240eba8fde5
- uses: google-github-actions/setup-gcloud@v2 # or specify different version if available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: google-github-actions/setup-gcloud@v2 # or specify different version if available
# uses: google-github-actions/setup-gcloud@v2
- uses: google-github-actions/setup-gcloud@f0990588f1e5b5af6827153b93673613abdc6ec7 # v2.1.1

with:
service_account_key: {% raw %}${{ secrets.GKE_SA_KEY }}{% endraw %}
project_id: {% raw %}${{ secrets.GKE_PROJECT }}{% endraw %}
Expand All @@ -172,7 +177,7 @@ jobs:
gcloud --quiet auth configure-docker

# Get the GKE credentials so we can deploy to the cluster
- uses: google-github-actions/get-gke-credentials@db150f2cc60d1716e61922b832eae71d2a45938f
- uses: google-github-actions/get-gke-credentials@v2 # or specify different version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: google-github-actions/get-gke-credentials@v2 # or specify different version
# uses: google-github-actions/get-gke-credentials@v2
- uses: google-github-actions/get-gke-credentials@6051de21ad50fbb1767bc93c11357a49082ad116 # v2.2.1

with:
cluster_name: {% raw %}${{ env.GKE_CLUSTER }}{% endraw %}
location: {% raw %}${{ env.GKE_ZONE }}{% endraw %}
Expand Down
Loading