Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update in authentication to follow the content style guide #34537

Conversation

AdityaSrivastava185
Copy link

Why:

Periods need to be removed from each list line, as each line is not a complete sentence (per our style guide)

Closes: Remove periods from list in about-mandatory-two-factor-authentication#about-eligibility-for-mandatory-2fa #34521

What's being changed (if available, include any code snippets, screenshots, or gifs):

Screenshot 2024-09-09 000816

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Sep 8, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/securing-your-account-with-two-factor-authentication-2fa/about-mandatory-two-factor-authentication.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Sep 9, 2024
@nguyenalex836
Copy link
Contributor

@AdityaSrivastava185 Thank you so much for opening a PR! ✨ Unfortunately, the following PR has already been set to merge and address this issue once our repo freeze ends on 9/16 - #34524

With that said, if you're looking for another issue to pick up while waiting, take a look at our help wanted section to find open issues you can work on 💛

Thank you for your willingness to contribute to our community!

@AdityaSrivastava185 AdityaSrivastava185 deleted the content-style-guide-update branch September 9, 2024 17:32
@Hellinheaven259

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants