sarif-support-for-code-scanning.md:runAutomationDetails fix
#34820
Conversation
The previous example was "2021-02-01 == February 2, 2021" which is not normal calendar use. The new example fixes this.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
bot
added
the
triage
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
nguyenalex836
added
content
|
@SwuduSusuwu Thank you for opening a PR! I believe this doc is following ISO date format, which should actually mean I'll get this triaged for review, just so another member of the team can confirm 💛 |
nguyenalex836
added
the
waiting for review
There was a problem hiding this comment.
Hi @SwuduSusuwu and thanks for raising a PR. You're right about the mistake.
Instead of just changing the written part to match the correct date, we should delete it altogether: different countries use different date systems and not everyone follows ISO8601, sadly. Stating the date doesn't add anything, either.
Once we resolve that point we can merge this on October 7th, after our freeze ends. Thank you!
| | my-analysis/tool1/ | my-analysis/tool1 | None | ||
| | my-analysis for tool1 | None | my-analysis for tool1 | ||
|
|
||
| * The run with an `id` of "my-analysis/tool1/2021-02-01" belongs to the category "my-analysis/tool1". Presumably, this is the run from February 2, 2021. | ||
| * The run with an `id` of "my-analysis/tool1/2021-02-01" belongs to the category "my-analysis/tool1". Presumably, this is the run from January 2, 2022. |
There was a problem hiding this comment.
| * The run with an `id` of "my-analysis/tool1/2021-02-01" belongs to the category "my-analysis/tool1". Presumably, this is the run from January 2, 2022. | |
| * The run with an `id` of "my-analysis/tool1/2021-02-01" belongs to the category "my-analysis/tool1". |
After calendar example, has "(note: this ISO8601 format is used in Europe + US, but your system locale can replace this)"
…m last commit Removes trailing spaces from last commit
Partial reuse (removes ambigious language from this)
|
Hi, I appreciate what you're trying to say with the new changes, but we'd be better off keeping this simple and simply deleting the line I noted in my last suggestion. |
|
@SwuduSusuwu Hello! 👋 Just wanted to make sure you saw @subatoi's last comment. Once you've deleted the note that he referenced, we'll be happy to get his merged 💛 |
nguyenalex836
added
more-information-needed
github-actions
bot
added
the
stale
|
This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process. |
nguyenalex836
removed
stale
github-actions
bot
added
the
triage
nguyenalex836
dismissed
subatoi’s stale review
Applied suggestions in previous review
nguyenalex836
removed
the
triage
|
@SwuduSusuwu I went ahead and removed the line noted in @subatoi's suggestion 💛 We'll go ahead and get this merged - thank you for raising a flag on this issue, and contributing to GitHub Docs! ✨ |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
The previous example was "2021-02-01 == February 2, 2021" which is not normal calendar use. The new example fixes this.
Why:
Closes: #34819
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
[ X ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
datadirectory.[ X ] For content changes, I have completed the self-review checklist.