Update test_helper.rb

Signed-off-by: Justin Kenyon <[email protected]>
github · Feb 5, 2025 · 98a466f · 98a466f
1 parent 4d94176
commit 98a466f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -252,15 +252,15 @@ def convert_from_real_to_query_safe(string)
   duplicate = string.dup.to_s
 
   UNSAFE_TO_SAFE_STRING_MAPPINGS.keys.each_with_object(duplicate) do |key, new_string|
-    new_string.gsub!(key, UNSAFE_TO_SAFE_STRING_MAPPINGS[key])
+    new_string = new_string.gsub(key, UNSAFE_TO_SAFE_STRING_MAPPINGS[key])
   end
 end
 
 def convert_from_query_safe_to_real(string)
   duplicate = string.dup.to_s
 
   SAFE_TO_UNSAFE_STRING_MAPPINGS.keys.each_with_object(duplicate) do |key, new_string|
-    new_string.gsub!(key, SAFE_TO_UNSAFE_STRING_MAPPINGS[key])
+    new_string = new_string.gsub(key, SAFE_TO_UNSAFE_STRING_MAPPINGS[key])
   end
 end