-
Notifications
You must be signed in to change notification settings - Fork 19
Convert to vitest #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR converts the test suite from Karma/Mocha to Vitest, modernizing the testing infrastructure for better developer experience and faster test execution.
Key changes:
- Replaced Karma/Mocha test runner with Vitest
- Updated test assertions from
assert
toexpect
syntax - Modernized Node.js version to 18 in CI workflows
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
vitest.config.ts | New Vitest configuration with happy-dom environment and global test functions |
test/setup.ts | Test setup file with polyfills and custom element registration for Vitest |
test/attachment.test.ts | Converted test file from Mocha/assert to Vitest/expect syntax |
test/.eslintrc.json | Removed Mocha-specific ESLint configuration |
package.json | Updated scripts and dependencies to use Vitest instead of Karma |
.github/workflows/publish.yml | Updated Node.js version from 14 to 18 |
.github/workflows/nodejs.yml | Updated Node.js version and workflow structure |
.eslintignore | Added test setup file to ignore list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
||
// Polyfill for DataTransfer if needed (based on test environment) | ||
if (typeof DataTransfer === 'undefined') { | ||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using @ts-ignore
suppresses TypeScript errors without explanation. Consider using @ts-expect-error
with a comment explaining why this is necessary, or properly type the global declaration.
// @ts-ignore |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
No description provided.