Skip to content

Conversation

TylerJDev
Copy link

No description provided.

@TylerJDev TylerJDev marked this pull request as ready for review August 15, 2025 19:08
@TylerJDev TylerJDev requested a review from a team as a code owner August 15, 2025 19:08
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 19:08
@TylerJDev TylerJDev marked this pull request as draft August 15, 2025 19:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts the test suite from Karma/Mocha to Vitest, modernizing the testing infrastructure for better developer experience and faster test execution.

Key changes:

  • Replaced Karma/Mocha test runner with Vitest
  • Updated test assertions from assert to expect syntax
  • Modernized Node.js version to 18 in CI workflows

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vitest.config.ts New Vitest configuration with happy-dom environment and global test functions
test/setup.ts Test setup file with polyfills and custom element registration for Vitest
test/attachment.test.ts Converted test file from Mocha/assert to Vitest/expect syntax
test/.eslintrc.json Removed Mocha-specific ESLint configuration
package.json Updated scripts and dependencies to use Vitest instead of Karma
.github/workflows/publish.yml Updated Node.js version from 14 to 18
.github/workflows/nodejs.yml Updated Node.js version and workflow structure
.eslintignore Added test setup file to ignore list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.


// Polyfill for DataTransfer if needed (based on test environment)
if (typeof DataTransfer === 'undefined') {
// @ts-ignore
Copy link
Preview

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using @ts-ignore suppresses TypeScript errors without explanation. Consider using @ts-expect-error with a comment explaining why this is necessary, or properly type the global declaration.

Suggested change
// @ts-ignore

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant