Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document replica-server-id command line option #510

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

druud62
Copy link

@druud62 druud62 commented Oct 26, 2017

Document replica-server-id command line option
https://github.com/druud

@shlomi-noach
Copy link
Contributor

Thank you for the documentation update!

Did you mean to include e75811f in this PR? It seems like a mistaken push.

@druud62
Copy link
Author

druud62 commented Oct 27, 2017

Indeed, I'll revert away the script/showdups from my fork.
I used it to check the amount of duplicate code source files, and there are plenty.
But I agree that such a tool doesn't belong in this repo.

BTW, I checked for duplicates, because there are different date-formats in the logging,
so I expected to find several log-modules. (Examples: "2017/10/26" vs. "2017-10-26")

@shlomi-noach
Copy link
Contributor

There are different date formats in the logs because I'm using 3rd party libraries.

Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like using the double-dashes convention. This was discussed in #127.

I don't care that the golang convention uses a single preceeding dash. The unix convention uses two and that's independent of the underlying programming language.

@druud62
Copy link
Author

druud62 commented Oct 29, 2017

I also prefer the double-dash convention. afe3ef3 now reverted.

@shlomi-noach
Copy link
Contributor

You may have reverted too much? There's nothing now in this PR

@druud62
Copy link
Author

druud62 commented Nov 1, 2017

All I see is that you merged, 9166671.
I probably still have to 'PR' my revert, 287ac78.
Will check that.

@rafsanbhuiyan
Copy link

Could you please explain to me the purpose of this code? And how can I contribute to the cause? I would love to help.
Thank you for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants