WIP: Switch travis to python3 #1319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jan 19, 2020
Lazer39
approved these changes
Apr 7, 2020
|
Actually, github-markup is explicitly calling https://github.com/github/markup/blob/master/lib/github/markups.rb#L52 Should that be changed in this PR? |
|
@aharpole would a PR updating python be accepted and released? |
|
Ping @aharpole :) |
|
Thanks for the ping! I think the right path forward here is to get this gem pointed to using python 3 and I've opened an issue internally to triage this work needed. Ordinarily I would welcome a PR but this is going to require some changes to systems beyond the gem itself to get fully shipped. |
|
Any developments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use python3 for running tests as python 2 is no longer supported