Added missing attributes for webhook events #1240
Conversation
yarisvt
changed the title
| /** | ||
| * Enum for the various Build status values. | ||
| */ | ||
| public enum BuildStatus { |
There was a problem hiding this comment.
I am wondering if this is not a duplication of the enum Constants.JobScope that we already have.
But BuildStatus seems a better name and feels more natural.
There was a problem hiding this comment.
I actually copied JobStatus into BuildStatus, they're the same except for the name. But I figured it's more clear to distinguish between jobs and builds
There was a problem hiding this comment.
Just there are build failure after your change.
I think this is due to the fact that there was already a BuildEvent with OBJECT_KIND build
gitlab4j-api/gitlab4j-api/src/main/java/org/gitlab4j/api/WebHookManager.java
Lines 179 to 190 in 7e8795e
I didn't look into all the details, but different/more cleanup might be necessary.
|
You're right, there already is a |
Updated the following events with missing properties
AbstractPushEventBuildCommitEventCommitEventIssueJobEventPipelineEventWikiPageEventEspecially,
PipelineEventandJobEventhave changed.PipelineEventno longer uses ajobsarray (Job), but abuildsarray (Build). I have not removed thejobsarray for backwards compatibility.JobEventno longer usesjobprefixed properties, butbuildprefixed properties. I have not removed thejobprefixed properties for backwards compatibility. I did change the object_kind tobuildas it should be according to the docs (used to bejobin version 12.x, but changed tobuildin version 13.x). This might break backwards compatibility.