Skip to content

Use Long instead of Integer in addMergeRequestAwardEmoji(..) #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions gitlab4j-api/src/main/java/org/gitlab4j/api/AwardEmojiApi.java
Original file line number Diff line number Diff line change
Expand Up @@ -436,9 +436,28 @@ public AwardEmoji addNoteAwardEmoji(Object projectIdOrPath, Long issueIid, Long
* @param name the name of the award emoji to add
* @return an AwardEmoji instance for the added award emoji
* @throws GitLabApiException if any exception occurs
* @deprecated use {@link #addMergeRequestAwardEmoji(Object, Long, Long, String)} instead
*/
@Deprecated
public AwardEmoji addMergeRequestAwardEmoji(
Object projectIdOrPath, Integer mergeRequestIid, Integer noteId, String name) throws GitLabApiException {
return addMergeRequestAwardEmoji(projectIdOrPath, mergeRequestIid.longValue(), noteId.longValue(), name);
}

/**
* Add an award emoji for the specified merge request note.
*
* <pre><code>GitLab Endpoint: POST /projects/:id/merge_requests/:merge_request_iid/notes/:noteId/award_emoji</code></pre>
*
* @param projectIdOrPath id, path of the project, or a Project instance holding the project ID or path
* @param mergeRequestIid the merge request IID of the merge request that owns the note
* @param noteId the note ID to add the award emoji to
* @param name the name of the award emoji to add
* @return an AwardEmoji instance for the added award emoji
* @throws GitLabApiException if any exception occurs
*/
public AwardEmoji addMergeRequestAwardEmoji(Object projectIdOrPath, Long mergeRequestIid, Long noteId, String name)
throws GitLabApiException {
GitLabApiForm form = new GitLabApiForm().withParam("name", name, true);
Response response = post(
Response.Status.CREATED,
Expand Down
Loading