Bugfix/merge request event object attributes #1277
Conversation
…where appropriate
…ent_object_attributes # Conflicts: # gitlab4j-models/src/main/java/org/gitlab4j/api/models/AbstractEpic.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/AbstractUser.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/Application.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/ApprovalRule.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/Board.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/CreatedChildEpic.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/Epic.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/GroupFilter.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/ImpersonationToken.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/IssueFilter.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/Iteration.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/Job.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/Label.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/MergeRequest.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/MergeRequestFilter.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/OauthTokenResponse.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/ProjectAccessToken.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/RelatedEpic.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/Runner.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/SystemHook.java # gitlab4j-models/src/main/java/org/gitlab4j/api/models/User.java # gitlab4j-models/src/main/java/org/gitlab4j/api/systemhooks/MergeRequestSystemHookEvent.java # gitlab4j-models/src/main/java/org/gitlab4j/api/webhook/AbstractPushEvent.java # gitlab4j-models/src/main/java/org/gitlab4j/api/webhook/BuildCommit.java # gitlab4j-models/src/main/java/org/gitlab4j/api/webhook/BuildEvent.java # gitlab4j-models/src/main/java/org/gitlab4j/api/webhook/EventCommit.java # gitlab4j-models/src/main/java/org/gitlab4j/api/webhook/PipelineEvent.java
|
The dates gave me a bit of a headache. As documented in the following issues, they come from GitLab in various formats. I hope you find my solution acceptable. |
|
I need to figure out your change and understand it. I am surprised by the change of the tests and the dates. I understand the GitLab is not consistent but those example json files are supposed to represent "real" JSON responses sent by GitLab. If you modify those, how are we making sure that this client continues to parse those JSON responses correctly? |
|
I changed the test data because it didn't match what I received from GitLab. And you mentioned here that this could be the case. Since the data from GitLab is inconsistent anyway, I didn't undo the change. But if you want me to, I'm happy to do so. Perhaps it would also make sense to only partially undo the change, as this would best reflect reality. |
|
I would say the main change to what @bdgould did are the custom Deserializer to make sure the library can handle multiple date formats. |
This is my contribution to finish the great work of @bdgould in Object Attributes #1198