Skip to content

[signing] Sigin: Offer manual fallback in case the extension can't open a browser#119

Merged
geropl merged 2 commits intomasterfrom
gpl/fix-cant-open-browser
Jan 29, 2025
Merged

[signing] Sigin: Offer manual fallback in case the extension can't open a browser#119
geropl merged 2 commits intomasterfrom
gpl/fix-cant-open-browser

Conversation

@geropl
Copy link
Member

@geropl geropl commented Jan 29, 2025

Description

Addresses an issue I see when trying to signin with cursor (appimage, on Linux):

  1. Stays in "Signing in" for 60s and then fails
    • image
  2. Logs read:
2025-01-28 17:36:24.236 [info] Logging in for the following scopes: function:deleteWorkspace function:getLoggedInUser function:getOwnerToken function:getSSHPublicKeys function:getWorkspace function:getWorkspaces function:sendHeartBeat function:startWorkspace function:stopWorkspace resource:default
2025-01-28 17:37:31.686 [error] Failed to load session: Cancelled
2025-01-28 17:37:31.686 [error] Failed to sign in

The idea here is to show a warning if openExternal returns false (hope that is the right signal).

Related Issue(s)

Fixes #

How to test

No clue. @filiptronicek any idea how to test this?

Documentation

/hold

…en a browser

Tool: gitpod/catfood.gitpod.cloud
@filiptronicek
Copy link
Member

@geropl you can test by going to the Run and Debug tab of VS Code and hitting play: that should open up a new VS Code window with the debug extension activated.

I've just tried by manually changing vscode.env.openExternal to just be false: signing in with the manually-copied URL worked flawlessly!

@geropl geropl marked this pull request as ready for review January 29, 2025 13:38
@geropl
Copy link
Member Author

geropl commented Jan 29, 2025

I've just tried by manually changing vscode.env.openExternal to just be false: signing in with the manually-copied URL worked flawlessly!

Awesome, then let's merge 😜

Is the release process automated, or do we need to "nudge" it somewhere? 🤔

@filiptronicek
Copy link
Member

@geropl seems like ESLint is complaining about you using " instead of ' for strings. I took the liberty to push a fix

@geropl geropl merged commit 2ffe187 into master Jan 29, 2025
1 check passed
@filiptronicek
Copy link
Member

@geropl: Is the release process automated, or do we need to "nudge" it somewhere? 🤔

AFAIK it's automated for the pre-release channel, but it requires a manual publish (IIRC a manual GitHub Action run) to do a latest release

@geropl
Copy link
Member Author

geropl commented Jan 29, 2025

Whoops, seems it might have missed your commit. Let me create a new PR

No, it's all in. Nice.

@filiptronicek
Copy link
Member

@geropl actually looks ok, the main commit this got merged into has my single quote fixes in it: 2ffe187

@filiptronicek filiptronicek deleted the gpl/fix-cant-open-browser branch January 29, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants