Don't use binary format for transport in public api client#120
Merged
mustard-mh merged 2 commits intomasterfrom Apr 28, 2025
Merged
Don't use binary format for transport in public api client#120mustard-mh merged 2 commits intomasterfrom
mustard-mh merged 2 commits intomasterfrom
Conversation
… http2 is not available
mustard-mh
approved these changes
Apr 28, 2025
Contributor
mustard-mh
left a comment
mustard-mh
left a comment
There was a problem hiding this comment.
Smoke tested it can connect using new build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't use binary format, binary format forces http2, it's preferable to downgrade to http1.1 if http2 is not available for some reason
Related Issue(s)
Fixes #
How to test
Documentation
/hold