Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deps off the project, fixes #2 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arichiardi
Copy link

As per title, fixes #2

@gja
Copy link
Owner

gja commented Sep 28, 2016

Thank you for the pull request. Let me think about this a bit. Even if it is a runtime dependency, I wanted to add log4j in the deps, so that this is the only library one needs to add to their project. Let me think about alternate ways to do this

@arichiardi
Copy link
Author

@gja of course! 😄 also consider that you don't always want your transitive deps to interfere with each other and 90% of the time you will need to specify a top level dependency to disambiguate the version that maven pulls in. What I mean is, if all your libs that use log4j pull different versions of it, who wins?

If you leave this to leiningen if I remember correctly the transitive dep closer to the vector top (meaning...smaller index) will win, but you'd better have control on that 😄

In any case, thanks for answering so promptly, I'd really love to see a log4j2 clojure lib shining. Log4j2 has unique features (context, async loggers, ...) and it is a pity that clojure.logging does not include it atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove org.apache.logging.log4j dependencies
2 participants