Update for Cython 3.x (Sourcery refactored) #16
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| self._x = float(value) | ||
| self._x = value |
There was a problem hiding this comment.
Function Point.x refactored with the following changes:
- Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
| self._y = float(value) | ||
| self._y = value |
There was a problem hiding this comment.
Function Point.y refactored with the following changes:
- Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
| for iter_nr in range(options.iter): | ||
| for _ in range(options.iter): |
There was a problem hiding this comment.
Lines 31-31 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| for iter_nr in range(options.iter): | ||
| for _ in range(options.iter): |
There was a problem hiding this comment.
Lines 30-30 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| for iter_nr in range(options.iter): | ||
| for _ in range(options.iter): |
There was a problem hiding this comment.
Lines 27-27 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| result_as_list = [prime for prime in p[:len_p]] | ||
| result_as_list = list(p[:len_p]) |
There was a problem hiding this comment.
Function primes refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
| if nb_primes > 1000: | ||
| nb_primes = 1000 | ||
|
|
||
| nb_primes = min(nb_primes, 1000) |
There was a problem hiding this comment.
Function primes refactored with the following changes:
- Replace comparison with min/max call (
min-max-identity) - Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace identity comprehension with call to collection constructor (
identity-comprehension)
This removes the following comments ( why? ):
# Let's copy the result into a Python list:
| if kmax > 1000: | ||
| kmax = 1000 | ||
| kmax = min(kmax, 1000) | ||
| k = 0 | ||
| n = 2 | ||
| while k < kmax: | ||
| i = 0 | ||
| while i < k and n % p[i] != 0: | ||
| i = i + 1 | ||
| i += 1 | ||
| if i == k: | ||
| p[k] = n | ||
| k = k + 1 | ||
| k += 1 |
There was a problem hiding this comment.
Function primes refactored with the following changes:
- Replace comparison with min/max call (
min-max-identity) - Replace assignment with augmented assignment [×2] (
aug-assign)
| min_time = min([np.mean(timings[algo]) for algo in algorithms]) | ||
| min_time = min(np.mean(timings[algo]) for algo in algorithms) |
There was a problem hiding this comment.
Function main refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
| auto_str = '' | ||
| for i, result in enumerate(self._rules): | ||
| auto_str += f'{i//4 % 2}{i//2 % 2}{i % 2} -> {result}\n' | ||
| auto_str = ''.join( | ||
| f'{i // 4 % 2}{i // 2 % 2}{i % 2} -> {result}\n' | ||
| for i, result in enumerate(self._rules) | ||
| ) |
There was a problem hiding this comment.
Function AutomatonRunner.__str__ refactored with the following changes:
- Use str.join() instead of for loop (
use-join)
sourcery-ai
bot
force-pushed
the
sourcery/development
branch
from
13826bd to
cac0a96
Compare
Pull Request #15 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
developmentbranch, then run:Help us improve this pull request!