Feature/dans hack/garys update #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the package provider a config param. If the provider is gem, start Puppet with an exec. Otherwise, use the service script.
Fixed dependency to either be set on the master starting exec or service.
Removed redundant variable namespace. Since the class is already called storedconfigs prefixig variables with this namespace is unneccassry. Made installation of mysql packages optional. This will allow the module to be usable on systems that already install mysql from another module. Condensed data, database_user, and grants in the single mysql::db define
Added reasonable defaults for puppet master params Added a manifest, autosign, and certname param. set reasonable defaults for certname, service, package and modulepath
To avoid duplicate configs when client and server are installed together.
Add parameters for puppet.conf configuration and to allow for the puppet master to be run with Passenger.
Remove the validation and _real variables for consistency. Some classes used this method, and some did not.
Fix parameters that have their defaults set in init.pp and remove the unneeded manifests parameter.
Add functionality to run puppet master with Passenger. If Passenger is to be used, ensure that that the puppet master cert exists, declare the passenger class, declare an Apache virtual host, modify puppet.conf, and ensure that the puppet master config.ru file is present.
Implement the parameters used in the puppetlabs-dashboard class.
Declare the concat::setup class and ensure its order.
This commit fixes the certificate check by setting a path and logging output on failure.
This commit declares two variables: $service_notify and $service_require and uses them to setup puppet.conf with concat.
The agent now checks to see if the puppet package has been declared. If it hasn't, it will do so.
Use the $puppet_agent_name variable for the puppet package.
If you install via rubygems, the puppet user and group is not created. This declaration will do that for you and allow you to pass a parameter for the UID and GID of the puppet user/group.
This commit will pass both puppet_agent_name and package_provider to the agent class.
This commit ensures that /etc/puppet is owned by the puppet user and group with a recurselimit of 1.
This fact is unnecessary as we pass certname as a parameter.
This commit checks to see if /etc/puppet is being managed elsewhere. If not, it will declare it. The agent and master class also append the require and notify parameters to accomodate for its package and service declarations.
If the puppet master package is not declared, we will declare it in the master class.
This commit removes the service declaration for the master class. We will use the exec to start/stop the service.
Rename the concat::fragment to puppet.conf-master and order it based on if we're using Passenger or not.
Ensure the owner/group on the $vardir and notify the puppet service if it's changed.
added 7 commits
August 16, 2011 13:44
Default the dbadapter to mysql, and set the puppet_master_package to be 'puppet' instead of 'puppet-server'
Activerecord is necessary for storeconfigs, and version 2.2.2 is compatible with ruby 1.8.5 and CentOS 5.
This will align our puppet.conf templates.
If you declare the master class but not the agent class, the puppet.conf-common concat fragment was not being declared. This commit checks to see if it's not defined - if it isn't, it will declare it for you.
glarizza
pushed a commit
that referenced
this pull request
Oct 19, 2012
This pull requests contains a refactor of the puppetlabs module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the following: