Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should multalm be private? #572

Open
Saransh-cpp opened this issue Mar 7, 2025 · 1 comment · May be fixed by #576
Open

Should multalm be private? #572

Saransh-cpp opened this issue Mar 7, 2025 · 1 comment · May be fixed by #576
Assignees
@ntessore @Saransh-cpp
Labels
maintenance Maintenance: refactoring, typos, etc.

Comments

@Saransh-cpp
Copy link
Member

Add your issue here

glass.fields.multalm is available under the glass namespace, but it is not displayed in documentation. I was wondering, given that it is only used internally by other functions, should it be private (and not under the glass namespace)?
@Saransh-cpp Saransh-cpp added the maintenance Maintenance: refactoring, typos, etc. label Mar 7, 2025
@ntessore
Copy link
Collaborator

ntessore commented Mar 7, 2025

Yeah, that function is only there for the random sampling. At least for now!

Saransh-cpp added a commit that referenced this issue Mar 7, 2025
@Saransh-cpp
gh-572: make multalm private
7e2c7a2
@Saransh-cpp Saransh-cpp linked a pull request Mar 7, 2025 that will close this issue
Open
5 tasks
@Saransh-cpp Saransh-cpp self-assigned this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntessore ntessore

@Saransh-cpp Saransh-cpp

Labels
maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-572: make multalm private glass-dev/glass
2 participants
@ntessore @Saransh-cpp