Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-572: make multalm private #576

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Saransh-cpp
Copy link
Member

Description

glass.fields.multalm is not used anywhere outside of the sampling function, so it should be private. This should not require deprecation as the function was never available in the documentation.

Closes: #572

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@Saransh-cpp Saransh-cpp added maintenance Maintenance: refactoring, typos, etc. api An (incompatible) API change labels Mar 7, 2025
@Saransh-cpp Saransh-cpp self-assigned this Mar 7, 2025
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples test is failing

@paddyroddy paddyroddy self-requested a review March 10, 2025 14:06
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api An (incompatible) API change maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should multalm be private?
2 participants